code review - Comparing Doubles in Visual Studio - a standard way to catch this? -

-

People,

Even experienced programmers sometimes write C # code like this: 

  Double X = 2.5; Double y = 3; In fact, it is common knowledge that two pairs (or floats) can never be equal to one another, if it is (x + 0.5 == 3) {// it will never be executed}

The way the computer handles floating point arithmetic

The problem is, everyone knows this, but in this way the code is still everywhere, ignoring it so much

The question for you:

  • You have with you in your development organization Have treated?
  • Is it common that the compiler should know that we all should really shout for VS-2010 so that if comparing two doubles / floats, then compiled time Include warning?

Update : People, thanks for the comments. I want to make it clear that I think most of the code above is wrong. Yes, you do not want to compare == doubles and floats at any time. Instead, you should use Epsilon-based comparison. Something is obvious. The real question here is "how can you decide on this problem", "how do you solve the technical issue"

Definitely point values ​​can be equal to one another, and if you have given them they will always be You should never compare equality using about equals, but why you need to understand it - and The example you have shown is not appropriate.

I do not think this is something that the compiler should give a necessary warning, but you would like to see if there is something that can be picked up on FxCop. I can not see it in, but it can be anywhere ...

Personally, I have full faith that enabled developers will find it in the code review, but it trusts you To start with, review a code, it depends on your developers when using double and when decimals are used, what I have found Often it is not ...


Comments

Post a Comment

Popular posts from this blog

c# - How to capture HTTP packet with SharpPcap -

-
I would like to capture all incoming HTTP packets on my machine. To do this, I am using SharpPcap which is a WinPcap The cover is. SharpPcap works very well, but it captures TCP packets and what it wants to do for me is a very low level. Does anyone know how can I easily get full HTTP requests / reactions from all these TCP packets? Thanks SharpPcap is already able to capture the packet in the same way That's what the virus does (just in the code instead of the GUI). And you can either either parse them directly or you can put them in the drive in the common .pcap file format. The steps to parse the capture are: Open a connection at any time Loop a while Or start capturing using an event callback Parsing the raw packet for the type you want If you are reading .PPP dump files In addition to calling you an offline capture reader is almost the same, there is no need to select an interface, and you can set the majority There is no need to do the modes. All st...
Read more

php - Multiple Select with Explode: only returns the word "Array" -

-
By using Wordpress I have created a multiple selection box so that users can select categories to exclude. When the page is initially loaded, I see my predefined default option. However, when I select a new value and I save ... I only see the word "Array" and have not chosen anything else? & lt; Class = "amultiple" id = "& lt; php echo $ value ['id'] ;? gt;" name = "& gt; php echo $ value ['id'] ;; gt; []" Multiple = "multiple" size = "8" & gt; & Lt ;? Php global option; Foreign currency ($ value as value $) {if (get_settings ($ value ['id']) === FALSE {$$ value ['id'] = $ value ['std']; } And {$$ value ['id'] = get_settings ($ value ['id']); }} $ Ranges = & amp; Amp; Categories ('type = post & orderbiz = name & amp; hide_empty = 1'); If ($ ranges) {$ ex_cat = implode (',', $ tt_cat_exclude); Forex Currency ($ range a...
Read more

jquery - SimpleModal Confirm fails to submit form -

-
I am trying to confirm jQuery to show yes / no confirmation when I submit a form. I had modified (in the last list) to capture and block form submissions. However, it only works with jQuery 1.2.6, a recent upgrade stops 1.3.2, if yes is clicked, then by submitting the form. But I can not understand what is wrong / inconsistent in my code now. Demo (which works in both versions of a simple window.href implementation). $ (document) .ready (function () {$ ('input.delete'). Click (function (e) {e.preventDefault (); var target = $ (e .target); Confirm ("Really delete this event?", Function () {target.click ()});});}); How about something like this? The idea of ​​catching clicks (and fire!) On the submitted event is not click event. $ (document) .ready (function () {$ ('# myForm'). Submit (function () {var f = this; Confirm (" Remove? ", Function () {$ (f). Submit ();}) Return; Return the initial session;}}}}; Hope That this is som...
Read more