codeigniter - How can I simplify this PHP? -

-

I have the following model functions with PHP. I know that I am repeating myself.

Can anybody simplify this code anyway? 

  function getTopMenus () {$ data [0] = 'root'; $ This- & gt; Db- & gt; Where ('parentid', 0); $ Q = $ it- & gt; DB- & gt; Get ('menu'); ($ Q-> num_rows ()> 0) {foreach ($ Q-> result_array ($ line as) {$ data [$ row ['id']] = $ row ['name '];}} $ Q- & gt; Free_Ralt (); $ data return;} function getheadMenus () {$ this-> db-> where (' parentid ', 0); $ Q = $ -> DB-> Receive ('menu'); if ($ Q-> num_rows ()> 0) {foreach ($ Q-> result_array (as the $ line) {$ Data [] = $ line;}} $ Q- & gt; Free_Ralt (); $ data return;} getrootMenus function () {$ this-> db-> where ('parentid', 0) ; $ Cue = $ it- & gt; db- & gt; get ('menu'); ($ Q-> num_rows ()> 0) {foreach ($ Q-> Results_re ( $ Line [$ data [$ row ['id']] = $ row ['name'];}} $ Q- & gt; Free_Ralt (); $ data return;}

I can see a simplification that you can see using a pass-by-reference factor things a function : 

  Create a function menu (and $ data) {$ this- & gt; Db- & gt; Where ('guardian', 0); $ Q = $ it- & gt; DB- & gt; Get ('menu'); ($ Q-> num_rows ()> 0) {foreach ($ Q-> result_array ($ line as) {$ data [$ row ['id']] = $ row ['name '];}} $ Q- & gt; Free_Ralt ();} getTopMenus () {$ data [0] =' root '; readyMenus ($ data); $ data return;} getRootMenus function} {prepareMenus ($ Data return; $ data return;}

There is also the possibility of using and there is a possibility to make the factor in the middle. Can reduce repetition, but can be considered as 'simplification' Is it or not?

Edit What do I mean here function getMenus (& $ data, $ Appendfunc) where $ ($ '>-> $' '> $ Q = $ THIS- & gt; DB- & gt; receive (' menu '); if ($ Q- & Gt; num_rows ()> 0) {foreach ($ Q-> result_are ($ as line) {$ appendFunc (& amp; $ data, $ line);}} $ Q- & gt; Function_address (menu; $ line) {$ data [$ row ['id']] = $ line ['name'];} function appended menu (& amp; $ data, $ line) {} $ Data [] = $ line; } GetTopMenus function () {$ data [0] = 'root'; Millman's ($ data, "appendop menu"); $ Return data; } Function getheadMenus () {getMenus ($ data, "appendHeadMenu"); $ Return data; } GetrootMenus function (getMenus ($ data, "appendTopMenu"); $ Return data; }


Comments

Post a Comment

Popular posts from this blog

c# - How to capture HTTP packet with SharpPcap -

-
I would like to capture all incoming HTTP packets on my machine. To do this, I am using SharpPcap which is a WinPcap The cover is. SharpPcap works very well, but it captures TCP packets and what it wants to do for me is a very low level. Does anyone know how can I easily get full HTTP requests / reactions from all these TCP packets? Thanks SharpPcap is already able to capture the packet in the same way That's what the virus does (just in the code instead of the GUI). And you can either either parse them directly or you can put them in the drive in the common .pcap file format. The steps to parse the capture are: Open a connection at any time Loop a while Or start capturing using an event callback Parsing the raw packet for the type you want If you are reading .PPP dump files In addition to calling you an offline capture reader is almost the same, there is no need to select an interface, and you can set the majority There is no need to do the modes. All st...
Read more

php - Multiple Select with Explode: only returns the word "Array" -

-
By using Wordpress I have created a multiple selection box so that users can select categories to exclude. When the page is initially loaded, I see my predefined default option. However, when I select a new value and I save ... I only see the word "Array" and have not chosen anything else? & lt; Class = "amultiple" id = "& lt; php echo $ value ['id'] ;? gt;" name = "& gt; php echo $ value ['id'] ;; gt; []" Multiple = "multiple" size = "8" & gt; & Lt ;? Php global option; Foreign currency ($ value as value $) {if (get_settings ($ value ['id']) === FALSE {$$ value ['id'] = $ value ['std']; } And {$$ value ['id'] = get_settings ($ value ['id']); }} $ Ranges = & amp; Amp; Categories ('type = post & orderbiz = name & amp; hide_empty = 1'); If ($ ranges) {$ ex_cat = implode (',', $ tt_cat_exclude); Forex Currency ($ range a...
Read more

jquery - SimpleModal Confirm fails to submit form -

-
I am trying to confirm jQuery to show yes / no confirmation when I submit a form. I had modified (in the last list) to capture and block form submissions. However, it only works with jQuery 1.2.6, a recent upgrade stops 1.3.2, if yes is clicked, then by submitting the form. But I can not understand what is wrong / inconsistent in my code now. Demo (which works in both versions of a simple window.href implementation). $ (document) .ready (function () {$ ('input.delete'). Click (function (e) {e.preventDefault (); var target = $ (e .target); Confirm ("Really delete this event?", Function () {target.click ()});});}); How about something like this? The idea of ​​catching clicks (and fire!) On the submitted event is not click event. $ (document) .ready (function () {$ ('# myForm'). Submit (function () {var f = this; Confirm (" Remove? ", Function () {$ (f). Submit ();}) Return; Return the initial session;}}}}; Hope That this is som...
Read more